Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: add egress-gateway-with-l7-policy test #2578

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ysksuzuki
Copy link
Member

egress-gateway-with-l7-policy checks if traffic from Pods that are selected by both Egress Gateway Policy and L7 Network Policy is properly SNATed with an Egress IP.

cilium/cilium#32828

@ysksuzuki
Copy link
Member Author

All tests have passed with cilium-cli-ci:1e249fd50f82d08ad0f60720417648b373420b02
cilium/cilium#32898

@ysksuzuki ysksuzuki marked this pull request as ready for review June 5, 2024 06:32
@ysksuzuki ysksuzuki requested review from a team as code owners June 5, 2024 06:32
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong: it seems the PR is doing two different things, 1) test egress-gw with L7 policy; 2) add testcase to assert egress-gw's SNAT for pod-to-external-service traffic. I would suggest splitting into two commits if that's the case.

Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for my CODEOWNERS

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2024
ysksuzuki added 2 commits June 6, 2024 11:15
This test case checks if the traffic selected by an egress
gateway policy is masqueraded with an Egress IP when the clients
send a request using DNS.

The case is mainly to check the compatibility of Egress Gateway
and L7 policy.

Signed-off-by: Yusuke Suzuki <[email protected]>
egress-gateway-with-l7-policy checks if traffic from Pods that
are selected by both Egress Gateway Policy and L7 Network Policy
is properly SNATed with an Egress IP.

Signed-off-by: Yusuke Suzuki <[email protected]>
@ysksuzuki ysksuzuki force-pushed the egress-gateway-with-l7-policy branch from 1e249fd to a89f5af Compare June 6, 2024 02:18
@ysksuzuki
Copy link
Member Author

Looks like multicluster is flaky
#2518

@julianwiedmann julianwiedmann merged commit 79dc975 into cilium:main Jun 6, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants