Fix clusteremesh status retrieval on Cilium v1.14 when kvstoremesh is enabled #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blamed commit broke clustermesh status retrieval on Cilium v1.14 when kvstoremesh is enabled. Indeed, although it already included a check to try to figure out whether the kvstoremesh status was not yet exposed by a given Cilium version, it did not account for v1.14 using a completely separate image (and binary name) for kvstoremesh. Let's fix this by adding the appropriate exception. Fixes: fa7e30e ("clustermesh: output kvstoremesh status as part of clustermesh status") Signed-off-by: Marco Iorio <[email protected]>
michi-covalent
approved these changes
May 30, 2024
1 task
squeed
approved these changes
May 31, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blamed commit broke clustermesh status retrieval on Cilium v1.14 when kvstoremesh is enabled. Indeed, although it already included a check to try to figure out whether the kvstoremesh status was not yet exposed by a given Cilium version, it did not account for v1.14 using a completely separate image (and binary name) for kvstoremesh. Let's fix this by adding the appropriate exception.
Fixes: fa7e30e ("clustermesh: output kvstoremesh status as part of clustermesh status")