Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: Add local redirect policy tests #2568

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented May 29, 2024

This PR introduces local redirect policy tests to the connectivity suite.

In order to break the circular dependency, there is a separate PR on cilium/cilium repo that enables these tests using a custom version of cilium-cli obtained from this PR changes. Here are successful test runs from the cilium/cilium PR CI runs -

Runs after addressing review comments -
https://github.com/cilium/cilium/actions/runs/9409627836/job/25920752091
https://github.com/cilium/cilium/actions/runs/9409627836/job/25919911738

https://github.com/cilium/cilium/actions/runs/9387516652/job/25850621644
https://github.com/cilium/cilium/actions/runs/9377202073/job/25819021276
https://github.com/cilium/cilium/actions/runs/9375976798/job/25815109405
https://github.com/cilium/cilium/actions/runs/9377202073/job/25818391762

Add local redirect policy connectivity tests.

@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from 731a6c5 to 1d0736c Compare May 30, 2024 00:25
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from 1d0736c to d32aa42 Compare May 31, 2024 19:42
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from d32aa42 to a3d742a Compare June 3, 2024 19:09
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from a3d742a to c76e70d Compare June 3, 2024 19:53
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from c76e70d to 1a7cc8b Compare June 4, 2024 00:35
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from 1a7cc8b to 99fa7a6 Compare June 4, 2024 18:29
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from 99fa7a6 to 09a48ef Compare June 4, 2024 19:24
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from 09a48ef to e1c9556 Compare June 5, 2024 01:41
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from e1c9556 to d218b6c Compare June 5, 2024 02:17
@aditighag aditighag marked this pull request as ready for review June 5, 2024 02:54
@aditighag aditighag requested review from a team as code owners June 5, 2024 02:54
Extend the features list with a flag
to enable local redirect policy.

Signed-off-by: Aditi Ghag <[email protected]>
aditighag added 2 commits June 6, 2024 15:37
It checks for a failed curl command without
any network policy drops. Used in follow-up commits
to validate expected result for LRP tests.
The results pertain to network policy as well
non network policy related checks, so move them
accordingly.

Signed-off-by: Aditi Ghag <[email protected]>
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditighag Nice work!

connectivity/tests/lrp.go Outdated Show resolved Hide resolved
connectivity/tests/lrp.go Outdated Show resolved Hide resolved
connectivity/check/peer.go Show resolved Hide resolved
Tests LRP connectivity scenarios with a configured
skipRedirectFromBackend flag:
 - client pod to LRP frontend
 - LRP backend to LRP frontend

Signed-off-by: Aditi Ghag <[email protected]>
Copy link
Member Author

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. @derailed Addressed the review comments.

connectivity/tests/lrp.go Outdated Show resolved Hide resolved
@aditighag aditighag force-pushed the pr/aditighag/lrp-tests branch from d218b6c to 63c6d3a Compare June 7, 2024 00:17
@aditighag aditighag removed the request for review from youngnick June 7, 2024 00:23
@aditighag aditighag merged commit 9c6de69 into cilium:main Jun 7, 2024
14 of 15 checks passed
@aditighag aditighag deleted the pr/aditighag/lrp-tests branch June 7, 2024 03:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants