fix: Azure BYOCNI workflow #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor-kurchenko
force-pushed
the
pr/vk/azure/oidc/fix
branch
from
ef3d492 to
155c668
Compare
This PR introduces a couple of fixes: 1. Workaround for the Azure BYOCNI workflow: asynchronous Azure OIDC token fetch to avoid token assertion issues. 2. Azure location changed to the `eastus2` that used less intensive. Signed-off-by: viktor-kurchenko <[email protected]>
viktor-kurchenko
force-pushed
the
pr/vk/azure/oidc/fix
branch
from
155c668 to
ea2d18d
Compare
viktor-kurchenko
force-pushed
the
pr/vk/azure/oidc/fix
branch
from
ea2d18d to
be41d21
Compare
christarazi
approved these changes
May 13, 2024
nbusseneau
approved these changes
May 14, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@michi-covalent I think you can mark the |
|
|
Due to the |
nickolaev
reviewed
May 16, 2024
| token=$(curl -H "Authorization: bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" "${ACTIONS_ID_TOKEN_REQUEST_URL}&audience=api://AzureADTokenExchange" | jq .value -r) | ||
| az login --service-principal -u ${{ secrets.AZURE_PR_CLIENT_ID }} -t ${{ secrets.AZURE_PR_TENANT_ID }} --federated-token $token --output none | ||
| # Sleep for 4 minutes | ||
| sleep 240 |
There was a problem hiding this comment.
Can we achieve this with a periodic check for availability and a nice message when the failure is due to timeout?
EDIT: Ah never mind, I see that the overall step is doing the loop every 4 mins. I expected a much quicker loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple of fixes:
eastus2that used less intensive.Workflow run example: https://github.com/cilium/cilium-cli/actions/runs/9063109497/job/24898372774?pr=2546
Workaround for: #2478