k8s: remove unused filter functionality from k8sclient.CiliumLogs #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the logic to retrieve all logs from Cilium Pods is implemented using `bufio.Scanner`. This might result in errors for long loglines. ``` Error reading Cilium logs: error reading cilium-agent logs for kube-system/cilium-c2sx7: bufio.Scanner: token too long ``` The only reason to use the `bufio.Scanner` is the support to filter the logs by a given regular expression. But this functionality is not used. Therefore, this commit removes the filter functionality and the usage of `bufio.Scanner`. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/ciliumlogs-without-filter-and-scanner
branch
from
052a903 to
0c7c9cf
Compare
thorn3r
approved these changes
Apr 26, 2024
asauber
approved these changes
Apr 30, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/ciliumlogs-without-filter-and-scanner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic to retrieve all logs from Cilium Pods is implemented using
bufio.Scanner. This might result in errors for long loglines - hiding the actual error.AFAIU, the only reason to use the
bufio.Scanneris the support for filtering the logs by a given regular expression. But this functionality is not used.Therefore, this commit removes the filter functionality and the usage of
bufio.Scanner.