Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert https://github.com/cilium/cilium-cli/pull/2355 #2477

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

michi-covalent
Copy link
Contributor

the CFP-25694 saga continues. now we are discussing other approaches 💭 let's unlock the connectivity package in the meantime to unblock people.

This reverts commit d473bfc.

Signed-off-by: Michi Mutsuzaki <[email protected]>
This reverts commit 0a07fc1.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent changed the title Revert #2355 Revert https://github.com/cilium/cilium-cli/pull/2355 Apr 10, 2024
@michi-covalent michi-covalent marked this pull request as ready for review April 10, 2024 15:11
@michi-covalent michi-covalent requested review from a team as code owners April 10, 2024 15:11
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:struggle:

@michi-covalent
Copy link
Contributor Author

https://github.com/cilium/cilium-cli/actions/runs/8633059991/job/23676910164?pr=2477 failed on Clean up AKS step. i'm shipping this.

@michi-covalent michi-covalent merged commit f4a02ed into main Apr 11, 2024
12 of 13 checks passed
@michi-covalent michi-covalent deleted the pr/michi/revert-struggle branch April 11, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants