Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use zip output for windows releases #2472

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jbpaux
Copy link
Contributor

@jbpaux jbpaux commented Apr 7, 2024

Windows users nearly never use tar.gz files but it's common to use zip files.

I suggest this PR to change in the releases the output format for windows binaries.

@jbpaux jbpaux requested a review from a team as a code owner April 7, 2024 11:44
@jbpaux jbpaux requested a review from derailed April 7, 2024 11:44
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbpaux Nice work! Thank you for this pr.

@jbpaux
Copy link
Contributor Author

jbpaux commented Apr 10, 2024

I've added the zip utility as it's not by default in the docker image. You can retrigger the workflow :)

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2024
@tklauser tklauser merged commit afc7b93 into cilium:main Apr 19, 2024
12 of 13 checks passed
@jbpaux jbpaux deleted the pr/zip-output-for-windows branch April 19, 2024 08:51
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants