Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: Move Version and HelmRepository from const to var #2439

Closed
wants to merge 1 commit into from

Conversation

michi-covalent
Copy link
Contributor

Make Version and HelmRepository variables instead of consts so that they can be overridden using build tags.

Make Version and HelmRepository variables instead of consts so that they
can be overridden using build tags.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent
Copy link
Contributor Author

chatted a bit with @tklauser about this offline. we decided to use go build -X flag to override consts as needed. closing this issue, i'll do some cleanup in #2437 to make it easier to override -X flag 🎏

@michi-covalent michi-covalent deleted the pr/michi/var-please branch March 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant