connectivity: Improve coverage of Ingress service #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
approved these changes
Mar 15, 2024
sayboras
added
the
needs-rebase
giorio94
force-pushed
the
mio/ingress-backend-service
branch
from
efc290a to
eff1aba
Compare
|
Rebased to fix conflict. |
giorio94
removed
the
needs-rebase
sayboras
added
the
needs-rebase
There's been some back and forth [1,2] on which service should be the backend of the ingress, as echo-other-node allows to cover the cluster mesh case as well, but is not available on single-node clusters. Given that they provide a different coverage, and we just discovered a bug which only happens when targeting a backend on the same node of the client, let's start creating two ingresses to cover both cases. [1]: f7a8822 ("connectivity: make ingress target echo-other-node deployment") [2]: 7e7fa6a ("ingress: Update backend service for Ingress") Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
mio/ingress-backend-service
branch
from
eff1aba to
b5b3530
Compare
giorio94
removed
the
needs-rebase
2 tasks
sayboras
changed the title
|
Testing was done as part of cilium/cilium#32367 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commits for additional details.
Blocked by cilium/cilium#31653