Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Hooks to the api package #2400

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

michi-covalent
Copy link
Contributor

Move Hooks to the api package so that the connectivity package can use the Hooks without creating a circular dependency once it moves to cilium/cilium repo.

Ref: cilium/design-cfps#9

Move Hooks to the api package so that the connectivity package can
use the Hooks without creating a circular dependency once it moves
to cilium/cilium repo.

Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <[email protected]>
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michi-covalent michi-covalent merged commit 037ba31 into main Mar 13, 2024
13 checks passed
@michi-covalent michi-covalent deleted the pr/michi/just-one-more-please branch March 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants