Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on github.com/mholt/archiver #2382

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

michi-covalent
Copy link
Contributor

CNCF license check complains about the usage of github.com/xi2/xz 1, which cilium-cli indirectly depends on via github.com/mholt/archiver. Use the archive and compress packages Go standard library instead to:

  • Untar Cilium and Tetragon bugtool outputs.
  • Zip the sysdump output directory.

Footnotes

  1. https://github.com/cilium/cilium/actions/runs/8191544402/job/22401012795?pr=31077

@michi-covalent
Copy link
Contributor Author

i manually tested by comparing cilium sysdump output against the main branch but please review carefully to make sure i didn't mess up anything 🚀🙏

@michi-covalent michi-covalent marked this pull request as ready for review March 10, 2024 06:10
@michi-covalent michi-covalent requested review from a team as code owners March 10, 2024 06:10
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from vendor team.

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 11, 2024
CNCF license check complains about the usage of github.com/xi2/xz [^1],
which cilium-cli indirectly depends on via github.com/mholt/archiver.
Use the archive and compress packages Go standard library instead to:

- Untar Cilium and Tetragon bugtool outputs.
- Zip the sysdump output directory.

[^1]: https://github.com/cilium/cilium/actions/runs/8191544402/job/22401012795?pr=31077

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent merged commit 6dee85c into main Mar 11, 2024
13 checks passed
@michi-covalent michi-covalent deleted the pr/michi/archive branch March 11, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants