Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ldflags for local-release #2370

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: update ldflags for local-release #2370

merged 1 commit into from
Mar 6, 2024

Conversation

chenrui333
Copy link
Contributor

followup #2362

@chenrui333 chenrui333 requested a review from a team as a code owner March 5, 2024 22:14
@chenrui333 chenrui333 requested a review from nathanjsweet March 5, 2024 22:14
@chenrui333
Copy link
Contributor Author

chenrui333 commented Mar 6, 2024 •
edited
Loading

cc @michi-covalent @nathanjsweet

michi-covalent
michi-covalent approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch. thanks for the fix!

@michi-covalent michi-covalent merged commit 5cdc2ff into cilium:main Mar 6, 2024
13 checks passed
@michi-covalent michi-covalent mentioned this pull request Mar 8, 2024
Closed
@senges
Copy link

senges commented Mar 11, 2024

Any chance we could release a patch version as cilium version won't work on github releases ?

Thanks for the fix !

@michi-covalent
Copy link
Contributor

yeah we are doing patch releases for cilium/cilium this week. we'll cut a cilium-cli release after that 🚀🙏

@senges
Copy link

senges commented Mar 11, 2024

Alright thanks 🙏

@rgl
Copy link

rgl commented Mar 12, 2024

should this have a regression test?

@lucasfcnunes lucasfcnunes mentioned this pull request Mar 13, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @senges @michi-covalent @rgl