Remove --cluster-name flag #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
commented
Feb 29, 2024
Comment on lines
-116
to
118
| // TODO: remove when removing "cluster-name" flag (marked as deprecated), | ||
| // kept for backwards compatibility | ||
| if k.params.ClusterName != "" { | ||
| helmMapOpts["cluster.name"] = k.params.ClusterName | ||
| } |
There was a problem hiding this comment.
we can't remove this block because we need to propagate the cluster name that gets auto-detected in https://github.com/cilium/cilium-cli/blob/main/install/autodetect.go#L150
I assert that #1347 is no longer an issue since we've removed the classic mode in #2327. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/cluster-name
branch
from
9e69d25 to
c01f73d
Compare
removing the temporary commit and marking it ready for review |
michi-covalent
force-pushed
the
pr/michi/cluster-name
branch
from
c01f73d to
1e31c23
Compare
michi-covalent
requested review from
derailed,
gandro,
marseel and
christarazi
gandro
approved these changes
Feb 29, 2024
christarazi
approved these changes
Feb 29, 2024
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Mar 1, 2024
The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Mar 1, 2024
The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
1 task
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Mar 5, 2024
[ upstream commit cfb1158 ] The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Mar 5, 2024
[ upstream commit cfb1158 ] The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Mar 5, 2024
[ upstream commit cfb1158 ] The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Mar 5, 2024
[ upstream commit cfb1158 ] The --cluster-name flag got removed in cilium/cilium-cli#2351. Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assert that #1347 is no longer an issue since we've removed the classic mode in #2327.