k8s: don't drop stdout of kubectl exec #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-empty stderr is interpreted as a command failure. However, calling code still assumes the output it gets is the output of the command, whereas we currently just return a pristine buffer. Fix it by returning the buffer. Signed-off-by: David Bimmler <[email protected]>
joamaki
approved these changes
Feb 27, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-empty stderr is interpreted as a command failure. However, calling code still assumes the output it gets is the output of the command, whereas we currently just return a pristine buffer.
Fix it by returning the buffer.
An example of why this is annoying: https://github.com/cilium/cilium/actions/runs/8043919487/job/21966754656#step:17:328