sniffer: improve handling of tcpdump termination #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AKS (BYOCNI) failure is unrelated. I'm stopping pressing the re-run button after hitting flakes five times in a row 😭 |
asauber
approved these changes
Feb 24, 2024
asauber
reviewed
Feb 24, 2024
Let's improve the handling of tcpdump termination by the Sniff utility in two main directions: * Don't return an error if tcpdump successfully exited before we determined it was ready. This can happen when running in sanity mode, as tcpdump exits after capturing a single packet matching the filter. Fixes the 'Failed to execute tcpdump: %!w(<nil>)' flake. * Explicitly assert that tcpdump didn't terminate in advance when running in assert mode, as otherwise we may have missed packets. Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
mio/sniffer-improve-termination-handling
branch
from
e2a5120 to
118037b
Compare
giorio94
added
the
ready-to-merge
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's improve the handling of tcpdump termination by the Sniff utility in two main directions:
Don't return an error if tcpdump successfully exited before we determined it was ready. This can happen when running in sanity mode, as tcpdump exits after capturing a single packet matching the filter. Fixes the
Failed to execute tcpdump: %!w(<nil>)'flake.Explicitly assert that tcpdump didn't terminate in advance when running in assert mode, as otherwise we may have missed packets.