Display formatted status during status wait #2261
Conversation
status/k8s.go
Outdated
| @@ -357,9 +358,18 @@ func (k *K8sStatusCollector) Status(ctx context.Context) (*Status, error) { | |||
| } | |||
| if !k.statusIsReady(s) && k.params.Wait { | |||
| time.Sleep(defaults.WaitRetryInterval) | |||
| statusFmt := s.Format() | |||
| for i := 1; i < lines; i++ { | |||
There was a problem hiding this comment.
Wondering if we could use a progress bar for this. Likely there might be other places that could benefit with user feedback.
We should probably use a help func to clear out the output if any.
nit: Docs might help here to indicate what this sequence does...
There was a problem hiding this comment.
Ah yes, the sequence is to set the cursor one line up.
There was a problem hiding this comment.
As for the progress bar, I'm not a big fan because:
- we can't really know the % progress
- as a user, I'd rather have details of what is going on (and see if something is stuck) in the same format as
cilium status)
status/k8s.go
Outdated
| @@ -357,13 +358,28 @@ func (k *K8sStatusCollector) Status(ctx context.Context) (*Status, error) { | |||
| } | |||
| if !k.statusIsReady(s) && k.params.Wait { | |||
| time.Sleep(defaults.WaitRetryInterval) | |||
| if k.params.Output != "json" { | |||
There was a problem hiding this comment.
I think we should use the predefined const. Also perhaps best to check summary vs json in case other fmts are exposed in the future.
There was a problem hiding this comment.
Yes. The const is in a package I can't import though, because that creates a dependency loop. Should we move the const to another package?
status/k8s.go
Outdated
| continue | ||
| } | ||
|
|
||
| for i := 1; i < lines; i++ { | ||
| fmt.Print("\033[A\033[2K") |
There was a problem hiding this comment.
How does this sequence fare on different platforms?
There was a problem hiding this comment.
It should be pretty safe on Linux and MacOS. On Windows, it ANSI codes seem to be well supported for Windows 10+.
|
@derailed I believe I've addressed all comments! |
|
I think all jobs need to be rerun, looks like there was an issue with |
raphink
force-pushed
the
wait-verbose
branch
from
21a4403 to
5b2b89e
Compare
|
OK, let's run again 👍🏼 |
still broken 😢 |
raphink
force-pushed
the
wait-verbose
branch
from
5b2b89e to
51d98c5
Compare
|
That's really weird though, that repo works on my machine 🤔 |
raphink
force-pushed
the
wait-verbose
branch
from
51d98c5 to
cb4fffc
Compare
Signed-off-by: Raphaël Pinson <[email protected]>
Signed-off-by: Raphaël Pinson <[email protected]>
Signed-off-by: Raphaël Pinson <[email protected]>
Signed-off-by: Raphaël Pinson <[email protected]>
Signed-off-by: Raphaël Pinson <[email protected]>
raphink
force-pushed
the
wait-verbose
branch
from
cb4fffc to
0089336
Compare
Signed-off-by: Raphaël Pinson [email protected]