Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error messaging for version command #2231

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ssttehrani
Copy link
Contributor

Refactored the error messaging logic for obtaining the running Cilium version in the GetRunningCiliumVersion function. This modification enhances clarity and provides more detailed error information when encountering issues.

Current implementation:
Screenshot 2024-01-11 at 3 46 37 PM
This error message is misleading since the pods are running in the specified namespace.

After this change, the correct error message is returned:
Screenshot 2024-01-11 at 3 48 42 PM

@ssttehrani ssttehrani requested a review from a team as a code owner January 11, 2024 12:25
@ssttehrani ssttehrani requested a review from derailed January 11, 2024 12:25
@maintainer-s-little-helper
Copy link

Commit d3664c4 does not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssttehrani Thank you for this update!

@tklauser tklauser merged commit 1932fed into cilium:main Jan 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants