Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: add third client scheduled on a different node #2183

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented Dec 14, 2023

for some upcoming tests we will need a new client scheduled on a different node than the first 2 clients. This commit adds this new client.

@jibi jibi added the area/CI Continuous Integration testing issue or flake label Dec 14, 2023
@jibi jibi requested a review from a team as a code owner December 14, 2023 11:28
@jibi jibi requested a review from christarazi December 14, 2023 11:28
@jibi jibi marked this pull request as draft December 14, 2023 12:11
@jibi jibi marked this pull request as ready for review December 14, 2023 14:34
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a third client needed?

@jibi
Copy link
Member Author

jibi commented Dec 15, 2023

Why is a third client needed?

as I added on the commit message, for some upcoming tests we will need a new client scheduled on a different node than the first 2 clients (and these 2 clients always run on the same node, as client2 uses pod affinity to run on the same node as client1)

@jibi jibi marked this pull request as draft December 15, 2023 08:52
for some upcoming tests we will need a new client scheduled on a
different node than the first 2 clients. This commit adds this new
client.

Signed-off-by: Gilberto Bertin <[email protected]>
Signed-off-by: Gilberto Bertin <[email protected]>
@jibi
Copy link
Member Author

jibi commented Dec 15, 2023

eks is failing due to a timeout, link to the green workflow after bumping it and running the workflow from PR https://github.com/cilium/cilium-cli/actions/runs/7220606369/job/19673889321?pr=2183

@jibi jibi marked this pull request as ready for review December 15, 2023 10:57
@jibi jibi requested a review from a team as a code owner December 15, 2023 10:57
@jibi jibi requested a review from nbusseneau December 15, 2023 10:57
@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 15, 2023
@ldelossa ldelossa merged commit d7703ca into main Dec 15, 2023
12 of 13 checks passed
@ldelossa ldelossa deleted the pr/jibi/client3 branch December 15, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants