Fix source interface determination in encryption tests when rp_filter is set to strict #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ff3df0 ("connectivity: fix encryption validation when running in ENI mode") fixed the encryption validation when running in ENI mode, by extending the source interface determination logic to additionally consider the source address, i.e., running ip route get dst from src iif lo The `iif lo` part is required, otherwise the command returns "RTNETLINK answers: Network is unreachable" in case the src address is not assigned to any local interface (which is expected, being src a pod IP). Yet, this fails with "RTNETLINK answers: Invalid cross-device link" in case rp_filter=1 (strict) is set of the given interface (lo in this case). Given that any local interface can be used there, let's switch it to cilium_host, as it is managed by Cilium, and we explicitly set rp_filter=0 to it. Fixes: 2ff3df0 ("connectivity: fix encryption validation when running in ENI mode") Fixes: cilium/cilium#29197 Signed-off-by: Marco Iorio <[email protected]>
brb
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2ff3df0 ("connectivity: fix encryption validation when running in ENI mode") fixed the encryption validation when running in ENI mode, by extending the source interface determination logic to additionally consider the source address, i.e., running
The
iif lopart is required, otherwise the command returns "RTNETLINK answers: Network is unreachable" in case the src address is not assigned to any local interface (which is expected, being src a pod IP).Yet, this fails with "RTNETLINK answers: Invalid cross-device link" in case rp_filter=1 (strict) is set of the given interface (lo in this case). Given that any local interface can be used there, let's switch it to
cilium_host, as it is managed by Cilium, and we explicitly set rp_filter=0 to it.Fixes: 2ff3df0 ("connectivity: fix encryption validation when running in ENI mode")
Fixes: cilium/cilium#29197