Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: Add more tests for Ingress Controller #2106

Merged
merged 1 commit into from
Nov 13, 2023
Merged

connectivity: Add more tests for Ingress Controller #2106

merged 1 commit into from
Nov 13, 2023

Conversation

sayboras
Copy link
Member

Description

This commit is to add two more tests related to Ingress Controller:

  • Deny policy on reserve:ingress identity
  • Deny policy on backend service of ingress (e.g. echo-same-node)

Relates: #2015

Testing

Testing was done locally as per below

$ ./cilium connectivity test --test ingress-service
...
[=] Test [pod-to-ingress-service]
..
[=] Test [pod-to-ingress-service-deny-all]
..
[=] Test [pod-to-ingress-service-deny-ingress-identity]
..
[=] Test [pod-to-ingress-service-deny-backend-service]
..
[=] Test [pod-to-ingress-service-allow-ingress-identity]
..
[=] Skipping Test [dns-only] (skipped by user)
[=] Skipping Test [to-fqdns] (skipped by user)

✅ All 5 tests (10 actions) successful, 53 tests skipped, 0 scenarios skipped.

@sayboras
connectivity: Add more tests for Ingress Controller
5595c70 
This commit is to add two more tests related to Ingress Controller:

- Deny policy on reserve:ingress identity
- Deny policy on backend service of ingress (e.g. echo-same-node)

Relates: cilium#2015
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras marked this pull request as ready for review November 13, 2023 12:54
@sayboras sayboras requested a review from a team as a code owner November 13, 2023 12:54
@sayboras sayboras requested a review from nebril November 13, 2023 12:54
sayboras added a commit to cilium/cilium that referenced this pull request Nov 13, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
c557312 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Nov 13, 2023
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@sayboras sayboras merged commit a06efa5 into cilium:main Nov 13, 2023
19 checks passed
@sayboras sayboras deleted the tam/ingress-controller-tests branch November 13, 2023 23:07
sayboras added a commit to cilium/cilium that referenced this pull request Nov 14, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
b04e17e 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 14, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
d978158 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
4be10b4 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for any
case having kpr=true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
561ea1c 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to cilium/cilium that referenced this pull request Nov 15, 2023
@sayboras
gha: Enable Ingress Controller tests in conformance-e2e
a7a3fcf 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
aanm pushed a commit to cilium/cilium that referenced this pull request Nov 20, 2023
@sayboras @aanm
gha: Enable Ingress Controller tests in conformance-e2e
c8ee339 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
@sayboras @pjablonski123
gha: Enable Ingress Controller tests in conformance-e2e
18a25c8 
The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
gandro pushed a commit to cilium/cilium that referenced this pull request Mar 28, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
c71fde4 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Sebastian Wicki <[email protected]>
gandro pushed a commit to cilium/cilium that referenced this pull request Mar 28, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
073aa5c 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Sebastian Wicki <[email protected]>
@sayboras sayboras mentioned this pull request Apr 2, 2024
Closed
gandro pushed a commit to cilium/cilium that referenced this pull request Apr 8, 2024
@sayboras @gandro
gha: Enable Ingress Controller tests in conformance-e2e
f4b4dbe 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Sebastian Wicki <[email protected]>
lmb pushed a commit to cilium/cilium that referenced this pull request Apr 9, 2024
@sayboras @lmb
gha: Enable Ingress Controller tests in conformance-e2e
bf6bf13 
[ upstream commit c8ee339 ]
[ upstream commit 9311af0 ]

The Ingress related connectivity tests are already available in cilium
cli, this commit is to enable the same in conformance e2e tests for some
tests having kpr as true.

Relates: cilium/cilium-cli#1533
Relates: cilium/cilium-cli#2106
Signed-off-by: Tam Mach <[email protected]>
Signed-off-by: Sebastian Wicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayboras @nebril