Make --nodes-without-cilium work with SPIRE #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change sets the same affinity on the SPIRE agent as CIlium has when --nodes-without-cilium is used, this prevents it from being scheduled where Cilium agent is not present. Signed-off-by: Maartje Eyskens <[email protected]>
|
I suggested using PodAffinity in cilium/cilium#28947; that should solve this without a CLI change needed. |
|
Sadly that will not work see cilium/cilium#28947 (comment) |
squeed
approved these changes
Nov 27, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the same affinity on the SPIRE agent as CIlium has when
--nodes-without-ciliumis used, this prevents it from being scheduled where Cilium agent is not present.