connectivity: Add GetTestOrDie() #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a convenient function GetTestOrDie(). There isn't much you can do if GetTest() fails anyways. Signed-off-by: Michi Mutsuzaki <[email protected]>
christarazi
approved these changes
Nov 9, 2023
tklauser
reviewed
Nov 9, 2023
| @@ -293,6 +293,16 @@ func (ct *ConnectivityTest) GetTest(name string) (*Test, error) { | |||
| panic("missing test descriptor for a registered name") | |||
| } | |||
|
|
|||
| // GetTestOrDie returns the test scope for test named "name" if found, | |||
| // or panics otherwise. | |||
| func (ct *ConnectivityTest) GetTestOrDie(name string) *Test { | |||
There was a problem hiding this comment.
nit: the upstream convention for functions that panic on failure is usually MustFoo (see e.g. netip.MustParseAddr), so this could be named MustGetTest instead.
michi-covalent
added a commit
that referenced
this pull request
Nov 9, 2023
Fixes: 89c7ff0 ("connectivity: Add GetTestOrDie()") Ref: #2096 (review) Signed-off-by: Michi Mutsuzaki <[email protected]>
tklauser
pushed a commit
that referenced
this pull request
Nov 9, 2023
Fixes: 89c7ff0 ("connectivity: Add GetTestOrDie()") Ref: #2096 (review) Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Jul 16, 2024
Fixes: 89c7ff04254f ("connectivity: Add GetTestOrDie()")
Ref: cilium/cilium-cli#2096 (review)
Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Aug 5, 2024
[ cherry-picked from cilium/cilium-cli repository ]
Fixes: 89c7ff04254f ("connectivity: Add GetTestOrDie()")
Ref: cilium/cilium-cli#2096 (review)
Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Aug 16, 2024
[ cherry-picked from cilium/cilium-cli repository ]
Fixes: 89c7ff04254f ("connectivity: Add GetTestOrDie()")
Ref: cilium/cilium-cli#2096 (review)
Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a convenient function GetTestOrDie(). There isn't much you can do if GetTest() fails anyways.