install: don't delete the 'aws-node' DaemonSet #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
approved these changes
May 4, 2021
pchaigno
approved these changes
May 27, 2021
|
Hi @bmcustodio. Could you please rebase the PR branch against latest Also there's a review remark from @pchaigno which you might want to address, if feasible? |
Instead of deleting the 'aws-node' DaemonSet, which is permanent, we can be gentler and just evict its pods by setting a node selector that won't ever be matched (unless someone wants it to by explicitly setting the required label). This allows 'cilium uninstall' to gracefully revert the 'aws-node' DaemonSet to its previous state, as it might contain customizations that would otherwise be lost. Signed-off-by: Bruno Miguel Custódio <[email protected]>
bmcustodio
force-pushed
the
bmcustodio-no-delete-aws-node
branch
from
b7af12c to
7c26ae4
Compare
maintainer-s-little-helper
bot
assigned tklauser and joestringer and unassigned joestringer
tklauser
approved these changes
Jun 24, 2021
|
For some reason the GitHub actions weren't triggered when you pushed a new version. I'll close and re-open the PR hoping that this will trigger the tests. |
|
Seems to have worked 🎉 |
joestringer
approved these changes
Jun 24, 2021
|
AKS failure is only due to the PR being opened from outside the cilium-cli repo. The code changes themselves only touch the EKS-specific jobs and codepaths so there should be no regression in the AKS job. Should be good to merge. |
joestringer
added
the
ready-to-merge
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deleting the
aws-nodeDaemonSet, which is permanent, we can be gentler and just evict its pods by setting a node selector that won't ever be matched (unless someone wants it to by explicitly setting the required label on a node).This allows
cilium uninstallto gracefully revert theaws-nodeDaemonSetto its previous state, as it might contain customizations that would otherwise be lost.