k8s/copy: check file size #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
force-pushed
the
pr/kkourt/copy-retry
branch
from
a542192 to
fa1c920
Compare
kkourt
force-pushed
the
pr/kkourt/copy-retry
branch
from
fa1c920 to
7319cec
Compare
christarazi
approved these changes
Oct 30, 2023
I've encountered an issue in a cluster, where the tetragon bugtool files were not complete. After debugging it seems that not all contents of the files were copied. This patch tries to handle this problem by getting the size of the file before the copy. If it is succesful in doing so, then it checks whether we have read everything and if not it returns an error. There is already support for handling partial reads in the code, so after this patch I am able to read the full size of the files. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/copy-retry
branch
from
7319cec to
1039fec
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered an issue in a cluster, where the tetragon bugtool files were not complete. After debugging it seems that not all the files were copied. This patch tries to handle this problem by getting the size of the file before the copy. If it is succesful in doing so, then it checks whether we have read everything and if not it returns an error.
There is already support for handling partial reads in the code, so after this patch I am able to read the full size.