Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo-external-node: Check if NodeWithoutCilium is enabled #2047

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

michi-covalent
Copy link
Contributor

Create echo-external-node deployment if and only if there is a node with "cilium.io/no-schedule=true" label. Otherwise Kubernetes cannot schedule this deployment.

Fixes: d541be5 ("connectivity: add echo-external deployment")
Fixes: cilium/cilium#27009

@michi-covalent michi-covalent temporarily deployed to ci October 16, 2023 17:28 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review October 16, 2023 18:15
@michi-covalent michi-covalent requested a review from a team as a code owner October 16, 2023 18:15
@michi-covalent michi-covalent requested a review from nebril October 16, 2023 18:15
@joestringer
Copy link
Member

Does this automatically disable the tests that rely on this deployment?

@michi-covalent
Copy link
Contributor Author

Does this automatically disable the tests that rely on this deployment?

yeah, it's a bit implicit but it checks if ExternalEchoPods is empty:

so these tests won't run if there is no echo-external-node pod.

Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one quality of life comment left inline.

connectivity/check/deployment.go Show resolved Hide resolved
Create echo-external-node deployment if and only if there is a node with
"cilium.io/no-schedule=true" label. Otherwise Kubernetes cannot schedule
this deployment.

Fixes: d541be5 ("connectivity: add echo-external deployment")
Fixes: cilium/cilium#27009

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent temporarily deployed to ci October 17, 2023 14:23 — with GitHub Actions Inactive
@michi-covalent michi-covalent requested a review from nebril October 17, 2023 14:23
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 17, 2023
@michi-covalent michi-covalent merged commit 76f1e23 into main Oct 17, 2023
19 checks passed
@michi-covalent michi-covalent deleted the pr/michi/external-node branch October 17, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium connectivity Test echo-external-pod doesn't come up
3 participants