Add node addr type to pod to host test #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn3r
approved these changes
Oct 17, 2023
|
@darox there's a golang-ci lint failure; can you take a look? |
Sure. I will have a look. |
darox
force-pushed
the
add-node-addr-type-to-pod-to-host-test
branch
from
807df7c to
739180d
Compare
fixed |
tklauser
reviewed
Nov 9, 2023
darox
force-pushed
the
add-node-addr-type-to-pod-to-host-test
branch
from
d8c98cc to
a196023
Compare
This commit changes the output format of the `pod-to-host` test cases. From: ``` Action [allow-all-except-world/pod-to-host/ping-ipv4-1 ``` to: ``` Action [allow-all-except-world/pod-to-host/ping-ipv4-internal-ip ``` by utilizing the `field Type v1.NodeAddressType` With this change, a user can immediately see if the ping to the ExternalIP or InternalIP of the node is failing. Without the need to run `kubectl get po -o wide` separately. Signed-off-by: darox <[email protected]>
darox
force-pushed
the
add-node-addr-type-to-pod-to-host-test
branch
from
a196023 to
741b502
Compare
tklauser
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the output format of
the
pod-to-hosttest cases.From:
to:
by utilizing the
field Type v1.NodeAddressTypeWith this change, a user can immediately see if the ping to the ExternalIP or InternalIP of the node is failing. Without the need to run
kubectl get po -o wideseparately.