connectivity test: Fix detectFeatures() logic #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
approved these changes
Oct 5, 2023
tklauser
approved these changes
Oct 5, 2023
f5ac977 unintentionally changed the detectFeatures logic by calling ExtractFromConfigMap() and ExtractFromNodes() on ct.Features instead of the features variable declared at the beginning of the loop [^1]. Fixes: f5ac977 ("Refactor extractFeaturesFromConfigMap()") [^1]: https://github.com/cilium/cilium-cli/blob/f5ac9776fb217d883edc9f916cb61cb916576693/connectivity/check/features.go#L518 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/bugfix
branch
from
ced978a to
3e5b98f
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f5ac977 unintentionally changed the detectFeatures logic by calling ExtractFromConfigMap() and ExtractFromNodes() on ct.Features instead of the features variable declared at the beginning of the loop 1.
Fixes: f5ac977 ("Refactor extractFeaturesFromConfigMap()")
Footnotes
https://github.com/cilium/cilium-cli/blob/f5ac9776fb217d883edc9f916cb61cb916576693/connectivity/check/features.go#L518 ↩