sysdump: Detect features from cilium-config ConfigMap #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call FeatureSet.ExtractFromConfigMap to extract features from cilium-config. - Add tasks related to SPIRE server if and only if "mutual-auth-spiffe" feature is enabled. Ref: #1962 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
requested review from
derailed,
a team and
meyskens
and removed request for
a team
|
requesting review from service mesh team 🚀🙏 |
derailed
reviewed
Oct 5, 2023
| @@ -263,6 +267,14 @@ func NewCollector(k KubernetesClient, o Options, startTime time.Time, cliVersion | |||
| } | |||
| c.log("ℹ️ %s ConfigMap not found in %s namespace", ciliumConfigMapName, c.Options.CiliumNamespace) | |||
| } | |||
| if c.CiliumConfigMap != nil && len(c.CiliumPods) > 0 { | |||
| ciliumVersion, err := c.Client.GetCiliumVersion(context.Background(), c.CiliumPods[0]) | |||
There was a problem hiding this comment.
Yikes! hopefully we'll have a better way to retrieve version info... perhaps helm values??
There was a problem hiding this comment.
yeah this is not great, but it needs to work even when you install cilium without doing helm install, like helm template | kubectl apply - or similar.
derailed
approved these changes
Oct 5, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1962