Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: Use slices.Clone #1943

Merged
merged 1 commit into from
Aug 31, 2023
Merged

connectivity: Use slices.Clone #1943

merged 1 commit into from
Aug 31, 2023

Conversation

brb
Copy link
Member

@brb brb commented Aug 31, 2023

Instead of make + copy. This should silence the linter's false positive.

@brb
connectivity: Use slices.Clone
caefe78 
Instead of make + copy. This should silence the linter's false positive.

Signed-off-by: Martynas Pumputis <[email protected]>
@brb brb added the area/CI Continuous Integration testing issue or flake label Aug 31, 2023
@brb brb temporarily deployed to ci August 31, 2023 09:28 — with GitHub Actions Inactive
@brb brb requested a review from tklauser August 31, 2023 09:28
@brb brb marked this pull request as ready for review August 31, 2023 09:28
@brb brb requested a review from a team as a code owner August 31, 2023 09:28
@brb brb requested a review from ysksuzuki August 31, 2023 09:28
@brb brb mentioned this pull request Aug 31, 2023
Merged
tklauser
tklauser approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser merged commit 484b294 into main Aug 31, 2023
@tklauser tklauser deleted the pr/brb/conn-fix-cli-go-err branch August 31, 2023 09:35
@tklauser tklauser mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@ysksuzuki ysksuzuki Awaiting requested review from ysksuzuki ysksuzuki was automatically assigned from cilium/sig-lb

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brb @tklauser