Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s to 1.28 #1909

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Bump k8s to 1.28 #1909

merged 1 commit into from
Aug 15, 2023

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser tklauser requested a review from a team as a code owner August 15, 2023 09:19
@tklauser tklauser requested a review from rolinh August 15, 2023 09:19
@tklauser tklauser marked this pull request as draft August 15, 2023 09:20
@tklauser tklauser force-pushed the pr/tklauser/wip-k8s-1.28 branch from 26361e1 to 04b3383 Compare August 15, 2023 09:21
@tklauser tklauser force-pushed the pr/tklauser/wip-k8s-1.28 branch from 04b3383 to 869f4f7 Compare August 15, 2023 11:10
@tklauser tklauser force-pushed the pr/tklauser/wip-k8s-1.28 branch from 869f4f7 to 510a0ae Compare August 15, 2023 11:10
@tklauser tklauser marked this pull request as ready for review August 15, 2023 11:11
@tklauser tklauser requested a review from a team as a code owner August 15, 2023 11:11
@tklauser tklauser requested a review from asauber August 15, 2023 11:11
@tklauser tklauser changed the title WIP: bump k8s to 1.28.0 Bump k8s to 1.28 Aug 15, 2023
Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/wip-k8s-1.28 branch from 510a0ae to 48c99c0 Compare August 15, 2023 11:14
@tklauser tklauser temporarily deployed to ci August 15, 2023 11:14 — with GitHub Actions Inactive
@@ -8,10 +8,6 @@ replace (

go.universe.tf/metallb => github.com/cilium/metallb v0.1.1-0.20220829170633-5d7dfb1129f7

// Using fork of client-go.
// Contains fix for exponential backoff for informers.
k8s.io/client-go => github.com/cilium/client-go v0.27.2-fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@@ -146,7 +146,6 @@ func createOrUpdateKNP(ctx context.Context, client *k8s.Client, knp *networkingv
// Overload the field that should stay unchanged.
policy.ObjectMeta.Labels = knp.ObjectMeta.Labels
policy.Spec = knp.Spec
policy.Status = networkingv1.NetworkPolicyStatus{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to this field

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was removed upstream by kubernetes/kubernetes#115843 ref. kubernetes/enhancements#2943

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how disappointing 😿

@tklauser tklauser merged commit 0610181 into main Aug 15, 2023
@tklauser tklauser deleted the pr/tklauser/wip-k8s-1.28 branch August 15, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants