k8s.NewClient: Initialize Helm action configuration #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 761761b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This reverts commit a1c8a1b. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/concurrent-struggle
branch
from
438ed25 to
0b8ef19
Compare
|
Commit 761761b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
michi-covalent
force-pushed
the
pr/michi/concurrent-struggle
branch
from
0b8ef19 to
e5a2912
Compare
michi-covalent
force-pushed
the
pr/michi/concurrent-struggle
branch
from
e5a2912 to
4f272a1
Compare
michi-covalent
changed the title
asauber
approved these changes
Jul 13, 2023
michi-covalent
force-pushed
the
pr/michi/concurrent-struggle
branch
from
4f272a1 to
6837189
Compare
Initialize Helm's action.Configuration once in k8s.NewClient so that all the schemes get registered before cilium-cli starts using the k8s.Client. According to https://github.com/kubernetes/apimachinery/blob/c9b3b3a37189129d0d80b894dc5d393ade9d3b79/pkg/runtime/scheme.go#L44-L45 runtime.Scheme is not thread-safe until the registration is complete. Fixes: #1794 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/concurrent-struggle
branch
from
6837189 to
d0aae28
Compare
michi-covalent
added
the
priority/release-blocker
sayboras
approved these changes
Jul 14, 2023
joamaki
approved these changes
Jul 17, 2023
chancez
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits:
action.Configurationink8s.NewClient.this time i tested the fix locally. without this fix, i hit #1794 after ~5 minutes by running
cilium status --waitrepeatedly in a loop. with this fix, it hasn't hit the issue for more than 2 hours.