Extend upgrade test for IPsec key rotation test #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
5a7d270 to
ade1392
Compare
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
ade1392 to
6e8bd3f
Compare
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
6e8bd3f to
3505a5d
Compare
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
bba7135 to
c533f45
Compare
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
c533f45 to
47d20f3
Compare
|
CI failed on "Clean up EKS":
|
pchaigno
reviewed
Jul 11, 2023
brb
requested changes
Jul 14, 2023
pchaigno
reviewed
Jul 18, 2023
This commit generalizes upgrade test so ipsec key rotation test can work on that with little extension. Basically it's just some rename works with no logic change, something like moving "--include-upgrade-test" to "--include-conn-disrupt-test". Signed-off-by: Zhichuan Liang <[email protected]>
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
4ed0089 to
ae905f0
Compare
pchaigno
approved these changes
Jul 20, 2023
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
ae905f0 to
d0769e2
Compare
This commit adds a new scenario for checking IPsec xfrm errors as a part of conn disrupt test. It compares the current xfrm status with previous record. In detail, the test consists of 3 steps: 1. Run "cilium-cli connectivity test --conn-disrupt-test-setup --include-conn-disrupt-test" to deploy connectivity sensitive pods, then record the current restart counts and xfrm error counts. 2. Perform IPsec key rotation. This part can be done in the ci-e2e. 3. Run "cilium-cli connectivity test --include-conn-disrupt-test" to check restart counts and xfrm error counts again, test fails if any diff found. Signed-off-by: Zhichuan Liang <[email protected]>
jschwinger233
force-pushed
the
gray/interruption-test
branch
from
d0769e2 to
3303538
Compare
asauber
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends upgrade test, so IPsec key rotation interruption test can base on the same workflow.
The expected test flow is:
Partially Fixes: cilium/cilium#26350
Signed-off-by: Zhichuan Liang [email protected]