sysdump: Use intermediate import package for supported envoy resources #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
ecdb8e4 to
93a12c6
Compare
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
93a12c6 to
4c37fcf
Compare
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
4c37fcf to
dd39fab
Compare
sayboras
added
the
dont-merge/preview-only
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
dd39fab to
1fcb3cf
Compare
sayboras
removed
the
dont-merge/preview-only
rolinh
requested changes
Jun 29, 2023
There was a problem hiding this comment.
I think there's now a new replace directive in v1.14.0-rc.0:
replace (
github.com/miekg/dns => github.com/cilium/dns v1.1.51-0.20220729113855-5b94b11b46fc
go.universe.tf/metallb => github.com/cilium/metallb v0.1.1-0.20220829170633-5d7dfb1129f7
k8s.io/client-go => github.com/cilium/client-go v0.27.2-fix
sigs.k8s.io/controller-tools => github.com/cilium/controller-tools v0.6.2
)
1fcb3cf to
e3ac1c0
Compare
Good catch, thanks 💯 |
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
e3ac1c0 to
b79773a
Compare
tklauser
requested changes
Jun 30, 2023
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
b79773a to
73fd80d
Compare
|
Commit 370fa54 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: Tam Mach <[email protected]>
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
tam/envoy-unmarshal-sync
branch
from
73fd80d to
7a87052
Compare
tklauser
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the similar happening again in the future, when we add more envoy resource types.
Relates: #1756
Relates: cilium/cilium#26469