connectivity: Add checks for agent error logs and drops due to missed tail calls #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
fb34a78 to
25199ad
Compare
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
d2d1f5b to
de152c5
Compare
brb
changed the title
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
de152c5 to
2849689
Compare
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
2849689 to
aedcb13
Compare
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
aedcb13 to
03b67f7
Compare
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
03b67f7 to
582bf40
Compare
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
582bf40 to
d4e6442
Compare
This commit adds a test case to check for errors in cilium-agent logs. The list of errors and helper utils were adopted from cilium/cilium/test/helper/utils.go. The error list diff from the former: * Removed all exceptions for "level=error" entries. * Added "Error in delegate stream, restarting" exception to "level=error". It's red-herring, and it will be chaned to warn or info by the SM team. Signed-off-by: Martynas Pumputis <[email protected]>
The test case is protected with --include-upgrade-test, as it's only relevant in the context of Cilium upgrades. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/connectivity-check-errors
branch
from
d4e6442 to
3f13fb8
Compare
pchaigno
reviewed
Jun 21, 2023
| @@ -217,6 +217,8 @@ func Run(ctx context.Context, ct *check.ConnectivityTest, addExtraTests func(*ch | |||
| // include --include-upgrade-tests" | |||
| return ct.Run(ctx) | |||
| } | |||
|
|
|||
| ct.NewTest("no-missed-tail-calls").WithScenarios(tests.NoMissedTailCalls()) | |||
There was a problem hiding this comment.
Probably out of scope, but I wonder if we could generalize that to more than just the upgrade and more than just missed tail calls drops. There are a lot of drops that we never expect to see. In a sense, they are the same as level=error log messages.
There was a problem hiding this comment.
Yep, good idea. Maybe let's start an issue to collect all thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.