while applying policies, wait for all expected policy revisions. #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
requested review from
a team and
nathanjsweet
and removed request for
a team
|
@cilium/sig-policy @nathanjsweet Can you confirm that every new/deleted policy will result in a separate revision (i.e. will not ever be batched up into a single revision)? |
|
Today, it will bump by at least one revision per resource update. I wouldn't consider that as API but it's unlikely to change any time particularly soon. I'd prefer a more formal way to associate the target revision with the target resource update like we used to have on the direct agent API, but that's probably quite a bit more work. Unclear whether that's worthwhile at this stage. |
Previously, we always waited for the r+1 revision, which in the case of multiple policies being applied may result in a race condition where some, but not all, of the policies are in place prior to proceeding with tests. As well, policy revision deltas are now counted per cluster, thus we can wait for the correct revision for each cluster. Signed-off-by: Tom Hadlaw <[email protected]>
tommyp1ckles
force-pushed
the
pr/tp/wait-for-all-revisions
branch
from
017e205 to
2950dbc
Compare
nathanjsweet
approved these changes
Jun 20, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we always waited for the r+1 revision, which in the case of multiple policies being applied may result in a race condition where some, but not all, of the policies are in place prior to proceeding with tests.