connectivity: Ability to add custom annotations to test deployment #1687
Conversation
|
Some of the CI failures look legitimate: |
This commit adds the ability to add labels or annotations to a newly created namespace. This commit itself does not contain any changes in functional behavior, the ability to add annotations will be used in a subsequent commit. Signed-off-by: Sebastian Wicki <[email protected]>
gandro
force-pushed
the
pr/gandro/connectivity-test-annotations
branch
from
689056e to
08452db
Compare
gandro
force-pushed
the
pr/gandro/connectivity-test-annotations
branch
from
08452db to
90c0189
Compare
gandro
force-pushed
the
pr/gandro/connectivity-test-annotations
branch
from
90c0189 to
8fc2027
Compare
Fixes. Issue was a copy-paste error in the namespace (dst vs src context) refactor commit. |
|
Looks good. One question: is there any need for setting annotations on all pods? Something like |
Oh that's a nice suggestion. Yeah I think supporting a wildcard match would be nice. |
This type will be used in a subsequent commit to specify the wanted annotations for a specific deployment or namespace. Unit tests are added to ensure the wildcard matching behavior. Signed-off-by: Sebastian Wicki <[email protected]>
This commit adds the ability to add custom namespace and pod annotations
to the `cilium connectivity test` deployment. The two flags are
`--deployment-pod-annotations` and `--namespace-annotations`.
For the pod annotations, we accept a JSON map which contains the
deployment name as the key, and the annotations as a string-to-string
map. For the namespace annotation, we simply expect a string-to-string
map.
We could have used Viper's `StringToString` map for the namespace
annotations, but not for the pod annotations, since there we would need
a "`StringToStringToString`" map. Therefore, to remain consistent
between the two flags, both flags exclusively JSON syntax.
If the deployment name in the annotations map ends with a `*` symbol,
then we perform a longest prefix match.
The flags are currently hidden, since we are not fully commited to this
command-line syntax yet and it might still change in the future.
Example:
```
$ cilium connectivity test \
--namespace-annotations='{"foo":"bar"}' \
--deployment-pod-annotations='{"client":{"baz":"qux"},"echo-*":{"quux":"corge"}}'
```
Signed-off-by: Sebastian Wicki <[email protected]>
gandro
force-pushed
the
pr/gandro/connectivity-test-annotations
branch
from
8fc2027 to
0329c76
Compare
|
Added the ability to support simple (i.e. prefix only) wildcard matches via |
gandro
added
the
ready-to-merge
connectivity: Ability to add custom annotations to test deployment
This commit adds the ability to add custom namespace and pod annotations
to the
cilium connectivity testdeployment. The two flags are--deployment-pod-annotationsand--namespace-annotations.For the pod annotations, we accept a JSON map which contains the
deployment name as the key, and the annotations as a string-to-string
map. For the namespace annotation, we simply expect a string-to-string
map.
We could have used Viper's
StringToStringmap for the namespaceannotations, but not for the pod annotations, since there we would need
a "
StringToStringToString" map. Therefore, to remain consistentbetween the two flags, both flags exclusively JSON syntax.
If the deployment name in the annotations map ends with a
*symbol,then we perform a longest prefix match.
The flags are currently hidden, since we are not fully commited to this
command-line syntax yet and it might still change in the future.
Example: