-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutual-auth: Update the terminology #1673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sayboras
force-pushed
the
tam/auth-terminology
branch
from
May 30, 2023 13:27
6e54190
to
f0c58e7
Compare
sayboras
force-pushed
the
tam/auth-terminology
branch
from
June 2, 2023 06:41
f0c58e7
to
a40253c
Compare
sayboras
force-pushed
the
tam/auth-terminology
branch
from
June 5, 2023 10:03
a40253c
to
93a0e84
Compare
sayboras
force-pushed
the
tam/auth-terminology
branch
from
June 5, 2023 10:43
93a0e84
to
a7db8c7
Compare
sayboras
force-pushed
the
tam/auth-terminology
branch
from
June 5, 2023 13:04
a7db8c7
to
9a97493
Compare
sayboras
changed the title
mutual-auth: Update the wording
mutual-auth: Update the terminology
Jun 5, 2023
sayboras
added
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Jun 5, 2023
rolinh
approved these changes
Jun 5, 2023
michi-covalent
approved these changes
Jun 5, 2023
The main change is to update vendor, also some updates are done on related CNP: - Adjust the CR based on latest spec (e.g. authentication.mode instead of auth.type) - Remove hard-code namespace so that the tests can run in user provided namespace via CLI - Rename the policy name to match file name (like what we have with other policies) - Remove the podToEndpoints scenarios as this scenario is mainly for testing L7 related feature, for mutual auth, L3/L4 is good enough Relates: cilium/cilium#24867 Signed-off-by: Tam Mach <[email protected]>
sayboras
force-pushed
the
tam/auth-terminology
branch
from
June 6, 2023 12:39
9a97493
to
9acf980
Compare
sayboras
removed
the
dont-merge/preview-only
Only for preview or testing, don't merge it.
label
Jun 6, 2023
As cilium/cilium#25904 is merged, remove preview only label after update the commit hash from cilium/cilium main branch. |
AKS (BYOCNI): hit #1204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to update vendor, also some updates are done on
related CNP:
of auth.type)
namespace via CLI
other policies)
testing L7 related feature, for mutual auth, L3/L4 is good enough
Relates: cilium/cilium#24867
Signed-off-by: Tam Mach [email protected]