Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutual-auth: Update the terminology #1673

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented May 30, 2023

The main change is to update vendor, also some updates are done on
related CNP:

  • Adjust the CR based on latest spec (e.g. authentication.mode instead
    of auth.type)
  • Remove hard-code namespace so that the tests can run in user provided
    namespace via CLI
  • Rename the policy name to match file name (like what we have with
    other policies)
  • Remove the podToEndpoints scenarios as this scenario is mainly for
    testing L7 related feature, for mutual auth, L3/L4 is good enough

Relates: cilium/cilium#24867
Signed-off-by: Tam Mach [email protected]

@sayboras sayboras temporarily deployed to ci May 30, 2023 12:07 — with GitHub Actions Inactive
@sayboras sayboras force-pushed the tam/auth-terminology branch from 6e54190 to f0c58e7 Compare May 30, 2023 13:27
@sayboras sayboras temporarily deployed to ci May 30, 2023 13:27 — with GitHub Actions Inactive
@sayboras sayboras force-pushed the tam/auth-terminology branch from f0c58e7 to a40253c Compare June 2, 2023 06:41
@sayboras sayboras temporarily deployed to ci June 2, 2023 06:41 — with GitHub Actions Inactive
@sayboras sayboras force-pushed the tam/auth-terminology branch from a40253c to 93a0e84 Compare June 5, 2023 10:03
@sayboras sayboras temporarily deployed to ci June 5, 2023 10:04 — with GitHub Actions Inactive
@sayboras sayboras force-pushed the tam/auth-terminology branch from 93a0e84 to a7db8c7 Compare June 5, 2023 10:43
@sayboras sayboras temporarily deployed to ci June 5, 2023 10:44 — with GitHub Actions Inactive
@sayboras sayboras force-pushed the tam/auth-terminology branch from a7db8c7 to 9a97493 Compare June 5, 2023 13:04
@sayboras sayboras temporarily deployed to ci June 5, 2023 13:04 — with GitHub Actions Inactive
@sayboras sayboras changed the title mutual-auth: Update the wording mutual-auth: Update the terminology Jun 5, 2023
@sayboras sayboras added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 5, 2023
@sayboras sayboras marked this pull request as ready for review June 5, 2023 13:06
@sayboras sayboras requested review from a team as code owners June 5, 2023 13:06
@sayboras sayboras requested review from rolinh and nathanjsweet June 5, 2023 13:06
The main change is to update vendor, also some updates are done on
related CNP:

- Adjust the CR based on latest spec (e.g. authentication.mode instead
  of auth.type)
- Remove hard-code namespace so that the tests can run in user provided
  namespace via CLI
- Rename the policy name to match file name (like what we have with
  other policies)
- Remove the podToEndpoints scenarios as this scenario is mainly for
  testing L7 related feature, for mutual auth, L3/L4 is good enough

Relates: cilium/cilium#24867
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the tam/auth-terminology branch from 9a97493 to 9acf980 Compare June 6, 2023 12:39
@sayboras sayboras temporarily deployed to ci June 6, 2023 12:39 — with GitHub Actions Inactive
@sayboras sayboras removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 6, 2023
@sayboras
Copy link
Member Author

sayboras commented Jun 6, 2023

As cilium/cilium#25904 is merged, remove preview only label after update the commit hash from cilium/cilium main branch.

@michi-covalent
Copy link
Contributor

AKS (BYOCNI): hit #1204

@michi-covalent michi-covalent merged commit fb2b586 into cilium:main Jun 6, 2023
@sayboras sayboras deleted the tam/auth-terminology branch June 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants