Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity/check: pass metrics to metricsIncrease by pointer #1664

Merged
merged 1 commit into from
May 26, 2023

Conversation

tklauser
Copy link
Member

To avoid copying this potentially large type and also work around the following erroneous govet warning:

copylocks: metricsIncrease passes lock by value: github.com/prometheus/client_model/go.MetricFamily contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)

Ref. https://github.com/cilium/cilium-cli/actions/runs/5087191687?pr=1661

To avoid copying this potentially large type and also work around the
following erroneous govet warning:

> copylocks: metricsIncrease passes lock by value: github.com/prometheus/client_model/go.MetricFamily contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)

Ref. https://github.com/cilium/cilium-cli/actions/runs/5087191687?pr=1661

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser requested a review from doniacld May 26, 2023 08:18
@tklauser tklauser requested a review from a team as a code owner May 26, 2023 08:18
@tklauser tklauser requested a review from asauber May 26, 2023 08:18
@tklauser tklauser temporarily deployed to ci May 26, 2023 08:18 — with GitHub Actions Inactive
@tklauser tklauser mentioned this pull request May 26, 2023
1 task
@tklauser tklauser merged commit ab3d4e5 into main May 26, 2023
@tklauser tklauser deleted the pr/tklauser/metrics-increase-pass-by-ptr branch May 26, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants