Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to use cilium-cli as a package #1609

Merged
merged 6 commits into from
May 18, 2023

Conversation

pippolo84
Copy link
Member

@pippolo84 pippolo84 commented May 9, 2023

This allows building a version of cilium-cli externally with extended connectivity tests and sysdump tasks.

@pippolo84 pippolo84 temporarily deployed to ci May 9, 2023 14:22 — with GitHub Actions Inactive
@pippolo84 pippolo84 force-pushed the pr/pippolo84/main-hooks branch from aa6252e to dc880c2 Compare May 9, 2023 15:41
@pippolo84 pippolo84 temporarily deployed to ci May 9, 2023 15:41 — with GitHub Actions Inactive
joamaki and others added 6 commits May 18, 2023 18:09
This allows building a version of cilium-cli externally with extended
tests and other functionalities.

Currently, cilium-cli may be extended with additional connectivity tests
and sysdump tasks.

Signed-off-by: Jussi Maki <[email protected]>
WithSetupFunc allows to register callbacks to be executed right before
the test begin, as part of the initial setup.

Signed-off-by: Fabio Falzoi <[email protected]>
Expose the clusters clients to give access to k8s objects to custom
setup callbacks.

Signed-off-by: Fabio Falzoi <[email protected]>
The previously added WithSetupFunc allows to register additional setup
callbacks that may modify the k8s objects in a test scenario.
WithFinalizer allows to register a finalizer to perform any needed
cleanup.

Signed-off-by: Fabio Falzoi <[email protected]>
Expose package template methods to allow connectivity test hooks
rendering yaml templates.

Signed-off-by: Fabio Falzoi <[email protected]>
GetTest allows to fetch an already existing test by its name. This may
be useful when a connectivity test hook wants to extend a test adding a
scenario.

Signed-off-by: Fabio Falzoi <[email protected]>
@pippolo84 pippolo84 force-pushed the pr/pippolo84/main-hooks branch from dc880c2 to d9e9342 Compare May 18, 2023 16:15
@pippolo84 pippolo84 temporarily deployed to ci May 18, 2023 16:15 — with GitHub Actions Inactive
@pippolo84 pippolo84 marked this pull request as ready for review May 18, 2023 16:16
@pippolo84 pippolo84 requested a review from a team as a code owner May 18, 2023 16:16
@pippolo84 pippolo84 requested a review from asauber May 18, 2023 16:16
@michi-covalent
Copy link
Contributor

multi cluster failure: https://github.com/cilium/cilium-cli/actions/runs/5015953697/jobs/8992202981?pr=1609#step:20:70

looks like some random transient error. re-triggering:

2023-05-18T16:29:27.161692175Z + kubectl+ kubectl --context gke_***_us-west2-a_cilium-cilium-cli-5015953697-classic-2 apply -f -
2023-05-18T16:29:27.162736913Z  --context gke_***_us-west2-a_cilium-cilium-cli-5015953697-classic-1 get secrets -n kube-system cilium-ca -oyaml
2023-05-18T16:29:27.390280200Z error: error reading input for Password

@michi-covalent
Copy link
Contributor

aks: filed #1643

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 18, 2023
@michi-covalent
Copy link
Contributor

who am i to argue with maintainer's little helper. it says ready to merge, i merge.

@michi-covalent michi-covalent merged commit cba1ed2 into cilium:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants