-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add junit output to connectivity test #1590
Add junit output to connectivity test #1590
Conversation
bb66cf7
to
8343bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably update our github workflows to write junit output right? are you planning to do it as a followup pull request?
I actually thought about adding a test but since I think adding one of the tests is enough, what do you think @michi-covalent? |
sounds good to me edit: maybe we can add the flag here => https://github.com/cilium/cilium-cli/blob/main/.github/workflows/kind.yaml#L152 |
I missed the kind workflow, even better we can easily upload the connectivity test output with the kind workflow. |
8343bc2
to
d329a33
Compare
d329a33
to
a235918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
a235918
to
9642486
Compare
This commit adds '--junit-file' option to connectivity test and when option is provided connectivity test output is written to the destination file as junit xml format. Signed-off-by: Birol Bilgin <[email protected]>
9642486
to
ddb4b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xml ftw
the button is too green not to click |
Junit format varies from implementation to implementation. The below references were used as references.
https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd
https://llg.cubic.org/docs/junit/
k8s e2e junit output
--junit-file
option is added to theconnectivity test
test output is converted to junit xml format, and written to the destination file
Fixes: #281