Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit output to connectivity test #1590

Merged

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented May 8, 2023

Junit format varies from implementation to implementation. The below references were used as references.

https://github.com/windyroad/JUnit-Schema/blob/master/JUnit.xsd
https://llg.cubic.org/docs/junit/
k8s e2e junit output

--junit-file option is added to the connectivity test
test output is converted to junit xml format, and written to the destination file

Fixes: #281

@brlbil brlbil requested a review from a team as a code owner May 8, 2023 13:49
@brlbil brlbil requested a review from asauber May 8, 2023 13:49
@brlbil brlbil temporarily deployed to ci May 8, 2023 13:49 — with GitHub Actions Inactive
@brlbil brlbil force-pushed the pr/brlbil/connectivity-junit-support branch from bb66cf7 to 8343bc2 Compare May 8, 2023 14:02
@brlbil brlbil temporarily deployed to ci May 8, 2023 14:02 — with GitHub Actions Inactive
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably update our github workflows to write junit output right? are you planning to do it as a followup pull request?

@brlbil
Copy link
Contributor Author

brlbil commented May 8, 2023

we should probably update our github workflows to write junit output right? are you planning to do it as a followup pull request?

I actually thought about adding a test but since cilium-cli tests run in the cluster I thought the output would not be very useful. Now I think we should add one even regardless of output is useful to test the functionality.

I think adding one of the tests is enough, what do you think @michi-covalent?

@michi-covalent
Copy link
Contributor

michi-covalent commented May 8, 2023

I think adding one of the tests is enough

sounds good to me

edit:

maybe we can add the flag here => https://github.com/cilium/cilium-cli/blob/main/.github/workflows/kind.yaml#L152

@brlbil
Copy link
Contributor Author

brlbil commented May 8, 2023

I missed the kind workflow, even better we can easily upload the connectivity test output with the kind workflow.
I will do this first thing tomorrow.

@brlbil brlbil marked this pull request as draft May 9, 2023 05:05
@brlbil brlbil force-pushed the pr/brlbil/connectivity-junit-support branch from 8343bc2 to d329a33 Compare May 9, 2023 05:42
@brlbil brlbil temporarily deployed to ci May 9, 2023 05:42 — with GitHub Actions Inactive
@brlbil brlbil force-pushed the pr/brlbil/connectivity-junit-support branch from d329a33 to a235918 Compare May 9, 2023 06:32
@brlbil brlbil temporarily deployed to ci May 9, 2023 06:32 — with GitHub Actions Inactive
@brlbil brlbil marked this pull request as ready for review May 9, 2023 07:59
@brlbil brlbil requested review from a team as code owners May 9, 2023 07:59
@brlbil brlbil requested a review from viktor-kurchenko May 9, 2023 07:59
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brlbil brlbil force-pushed the pr/brlbil/connectivity-junit-support branch from a235918 to 9642486 Compare May 9, 2023 11:06
@brlbil brlbil temporarily deployed to ci May 9, 2023 11:07 — with GitHub Actions Inactive
This commit adds '--junit-file' option to connectivity test
and when option is provided connectivity test output
is written to the destination file as junit xml format.

Signed-off-by: Birol Bilgin <[email protected]>
@brlbil brlbil force-pushed the pr/brlbil/connectivity-junit-support branch from 9642486 to ddb4b63 Compare May 9, 2023 12:31
@brlbil brlbil temporarily deployed to ci May 9, 2023 12:34 — with GitHub Actions Inactive
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml ftw

@michi-covalent
Copy link
Contributor

the button is too green not to click

@michi-covalent michi-covalent merged commit eefbd28 into cilium:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

junit output for connectivity test
3 participants