Add helm mode test coverage for AKS BYOCNI #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
bcf5605 to
ba7312d
Compare
michi-covalent
changed the title
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
ba7312d to
3b4374c
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
3b4374c to
e6aaf96
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
e6aaf96 to
d664742
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
d664742 to
e0d7b5e
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
e0d7b5e to
9a2f21a
Compare
michi-covalent
changed the title
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
576fe97 to
8f6074e
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
8f6074e to
b9a8ae7
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
b9a8ae7 to
aa5c95c
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
aa5c95c to
b8428f0
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
b8428f0 to
36c2421
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
36c2421 to
6ac85eb
Compare
viktor-kurchenko
approved these changes
May 10, 2023
gandro
approved these changes
May 10, 2023
kaworu
approved these changes
May 10, 2023
There was a problem hiding this comment.
Relay check changes LGTM, I like @viktor-kurchenko suggestion about splitting into two functions.
Fixes: #1566 Signed-off-by: Michi Mutsuzaki <[email protected]>
- Call ServerStatus with a shorter timeout than what's passed into waitForRelay so that we can call it multiple times before the context gets cancelled. Sometimes ServerStatus simply gets stuck until the context gets cancelled, in which case we end up calling ServerStatus only once before giving up. - Sometimes GetFlows() returns EOF even though we specify the follow flag. This seems to happen when both res.NumUnavailableNodes and res.NumConnectedNodes are nil. Add an extra check to make sure that Hubble Relay started receiving flows before returning from waitForRelay(). Here is a sample failure that was caused by GetFlows() returning EOF: https://github.com/cilium/cilium-cli/actions/runs/4928750068/jobs/8812246128#step:15:286 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
6ac85eb to
fecd9d4
Compare
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
fecd9d4 to
d9c019a
Compare
asauber
approved these changes
May 11, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
force-pushed
the
pr/michi/aks-struggle
branch
from
d9c019a to
9cb9a27
Compare
|
removed the test commit. time to 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1566
ended up adding an extra commit to make waitForRelay() more robust: e2e7202 cc @cilium/sig-hubble
Signed-off-by: Michi Mutsuzaki [email protected]