Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass --insecure to curl #1564

Merged
merged 1 commit into from
May 25, 2023
Merged

Allow to pass --insecure to curl #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions connectivity/check/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ type Parameters struct {

ConnectTimeout time.Duration
RequestTimeout time.Duration
CurlInsecure bool

CollectSysdumpOnFailure bool
SysdumpOptions sysdump.Options
Expand Down
3 changes: 3 additions & 0 deletions connectivity/check/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,9 @@ func (ct *ConnectivityTest) CurlCommand(peer TestPeer, ipFam IPFamily, opts ...s
if requestTimeout := ct.params.RequestTimeout.Seconds(); requestTimeout > 0.0 {
cmd = append(cmd, "--max-time", strconv.FormatFloat(requestTimeout, 'f', -1, 64))
}
if ct.params.CurlInsecure {
cmd = append(cmd, "--insecure")
}

cmd = append(cmd, opts...)
cmd = append(cmd, fmt.Sprintf("%s://%s%s",
Expand Down
1 change: 1 addition & 0 deletions internal/cli/cmd/connectivity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ func newCmdConnectivityTest() *cobra.Command {

cmd.Flags().DurationVar(&params.ConnectTimeout, "connect-timeout", defaults.ConnectTimeout, "Maximum time to allow initiation of the connection to take")
cmd.Flags().DurationVar(&params.RequestTimeout, "request-timeout", defaults.RequestTimeout, "Maximum time to allow a request to take")
cmd.Flags().BoolVar(&params.CurlInsecure, "curl-insecure", false, "Pass --insecure to curl")

cmd.Flags().BoolVar(&params.CollectSysdumpOnFailure, "collect-sysdump-on-failure", false, "Collect sysdump after a test fails")

Expand Down