Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to install Cilium CLI executable #1563

Merged
merged 1 commit into from
May 2, 2023

Conversation

brb
Copy link
Member

@brb brb commented May 2, 2023

To reduce the boilerplate in cilium/cilium/.github/workflows.

$ cd cilium/.github
$ git grep 'Install Cilium CLI' | wc -l
39

Test run cilium/cilium#25228.

@brb brb added the area/CI Continuous Integration testing issue or flake label May 2, 2023
@brb brb temporarily deployed to ci May 2, 2023 11:11 — with GitHub Actions Inactive
@brb brb force-pushed the pr/brb/gh-action-install-cli branch from 146380d to 46a527e Compare May 2, 2023 11:21
@brb brb temporarily deployed to ci May 2, 2023 11:21 — with GitHub Actions Inactive
@brb brb force-pushed the pr/brb/gh-action-install-cli branch from 46a527e to ee0ae24 Compare May 2, 2023 11:26
@brb brb force-pushed the pr/brb/gh-action-install-cli branch from ee0ae24 to f00f917 Compare May 2, 2023 11:27
@brb brb temporarily deployed to ci May 2, 2023 11:27 — with GitHub Actions Inactive
To reduce the boilerplate in cilium/cilium/.github/workflows.

    $ cd cilium/.github
    $ git grep 'Install Cilium CLI' | wc -l
    39

Signed-off-by: Martynas Pumputis <[email protected]>
@brb brb force-pushed the pr/brb/gh-action-install-cli branch from f00f917 to c57db9c Compare May 2, 2023 11:33
@brb brb temporarily deployed to ci May 2, 2023 11:33 — with GitHub Actions Inactive
@brb brb marked this pull request as ready for review May 2, 2023 11:44
@brb brb requested a review from a team as a code owner May 2, 2023 11:44
@brb brb requested a review from squeed May 2, 2023 11:44
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it

@michi-covalent
Copy link
Contributor

patiently waiting for the button to become green.

@michi-covalent
Copy link
Contributor

as green as 🥦

@michi-covalent michi-covalent merged commit d3c7168 into main May 2, 2023
@michi-covalent michi-covalent deleted the pr/brb/gh-action-install-cli branch May 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants