Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity/tests: omit IPs and vendor name from test names #1545

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 27, 2023

Construct the test names using the generic string "external" and the IP
that is actually used, e.g. using the external IP 1.2.3.4 would lead to
the test being named "external-1234".

Also change all references to specific IP addresses from the tests and
manifests and replace them by External{,Other}{IP,CIDR} placeholders.

Fixes #1542

@tklauser tklauser requested a review from a team as a code owner April 27, 2023 07:43
@tklauser tklauser requested a review from squeed April 27, 2023 07:43
@tklauser tklauser temporarily deployed to ci April 27, 2023 07:43 — with GitHub Actions Inactive
Construct the test names using the generic string "external" and the IP
that is actually used, e.g. using the external IP 1.2.3.4 would lead to
the test being named "external-1234".

Also change all references to specific IP addresses from the tests and
manifests and replace them by External{,Other}{IP,CIDR} placeholders.

Fixes #1542

Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser force-pushed the pr/tklauser/connectivity-world-test-name branch from 742f724 to 65064ab Compare April 27, 2023 08:10
@tklauser tklauser temporarily deployed to ci April 27, 2023 08:10 — with GitHub Actions Inactive
@tklauser tklauser changed the title connectivity/tests: omit vendor name from test name connectivity/tests: omit IPs and vendor name from test names Apr 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 27, 2023
@tklauser tklauser merged commit 4b91b5f into main Apr 27, 2023
@tklauser tklauser deleted the pr/tklauser/connectivity-world-test-name branch April 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading test name: cloudflare-1111
2 participants