Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Support --nodes-without-cilium in Helm install mode #1498

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

christarazi
Copy link
Member

  • Fix quotation for Cilium schedule affinity
  • install: Support --nodes-without-cilium in Helm install mode

christarazi and others added 2 commits April 10, 2023 15:22
Without this, the following error occurs when configuring
`--nodes-without-cilium`:

```
Error: Unable to install Cilium: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Affinity: v1.Affinity.NodeAffinity: v1.NodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution: v1.NodeSelector.NodeSelectorTerms: []v1.NodeSelectorTerm: v1.NodeSelectorTerm.MatchExpressions: []v1.NodeSelectorRequirement: v1.NodeSelectorRequirement.Values: []string: ReadString: expects " or n, but found t, error found in #10 byte of ...|values":[true]}]}]}}|..., bigger context ...|ium.io/no-schedule","operator":"NotIn","values":[true]}]}]}},"podAntiAffinity":{"requiredDuringSched|...
```

Co-authored-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Chris Tarazi <[email protected]>
@christarazi christarazi temporarily deployed to ci April 10, 2023 22:24 — with GitHub Actions Inactive
@christarazi christarazi changed the title pr/christarazi/nodes without cilium helm install: Support --nodes-without-cilium in Helm install mode Apr 10, 2023
@christarazi christarazi marked this pull request as ready for review April 10, 2023 22:24
@christarazi christarazi requested a review from a team as a code owner April 10, 2023 22:24
@christarazi christarazi requested a review from asauber April 10, 2023 22:24
@michi-covalent michi-covalent merged commit f9deda6 into master Apr 10, 2023
@michi-covalent michi-covalent deleted the pr/christarazi/nodes-without-cilium-helm branch April 10, 2023 23:23
christarazi pushed a commit that referenced this pull request Apr 11, 2023
Fixes: #1498

Signed-off-by: Michi Mutsuzaki <[email protected]>
christarazi pushed a commit that referenced this pull request Apr 11, 2023
Fixes: #1498

Signed-off-by: Michi Mutsuzaki <[email protected]>
tklauser pushed a commit that referenced this pull request Apr 11, 2023
Fixes: #1498

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit to michi-covalent/cilium that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants