-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a l7 header replace test #1463
Merged
tklauser
merged 1 commit into
cilium:master
from
meyskens:meyskens/http-header-replace-test
Mar 21, 2023
Merged
Add a l7 header replace test #1463
tklauser
merged 1 commit into
cilium:master
from
meyskens:meyskens/http-header-replace-test
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyskens
force-pushed
the
meyskens/http-header-replace-test
branch
from
March 20, 2023 08:57
f6618a2
to
e9db309
Compare
meyskens
force-pushed
the
meyskens/http-header-replace-test
branch
from
March 20, 2023 09:40
e9db309
to
fdd7924
Compare
jrajahalme
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the added coverage!
meyskens
force-pushed
the
meyskens/http-header-replace-test
branch
from
March 20, 2023 12:56
fdd7924
to
5d6b9d0
Compare
meyskens
force-pushed
the
meyskens/http-header-replace-test
branch
from
March 21, 2023 08:25
5d6b9d0
to
89065d8
Compare
This adds a test for the L7 policy to add/replace a HTTP header in a request. It does this by sending a request to a new endpoint that required an auth header, which will succeed if injected from a secret Signed-off-by: Maartje Eyskens <[email protected]>
meyskens
force-pushed
the
meyskens/http-header-replace-test
branch
from
March 21, 2023 08:27
89065d8
to
b3bce4f
Compare
squeed
approved these changes
Mar 21, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 21, 2023
This looks ready to merge - is the comment above still relevant? |
The release got cut yesterday and PR updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for the L7 policy to add/replace a HTTP header in a request. It does this by sending a request to a new endpoint that required an auth header, which will succeed if injected from a secret.
This came up while needing a test for cilium/cilium#24020 and it will work against the current Cilium version where it was previously not tested in Ginkgo.