Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a l7 header replace test #1463

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

meyskens
Copy link
Member

@meyskens meyskens commented Mar 20, 2023

This adds a test for the L7 policy to add/replace a HTTP header in a request. It does this by sending a request to a new endpoint that required an auth header, which will succeed if injected from a secret.

This came up while needing a test for cilium/cilium#24020 and it will work against the current Cilium version where it was previously not tested in Ginkgo.

@meyskens meyskens temporarily deployed to ci March 20, 2023 08:54 — with GitHub Actions Inactive
@meyskens meyskens force-pushed the meyskens/http-header-replace-test branch from f6618a2 to e9db309 Compare March 20, 2023 08:57
@meyskens meyskens temporarily deployed to ci March 20, 2023 08:58 — with GitHub Actions Inactive
@meyskens meyskens force-pushed the meyskens/http-header-replace-test branch from e9db309 to fdd7924 Compare March 20, 2023 09:40
@meyskens meyskens temporarily deployed to ci March 20, 2023 09:40 — with GitHub Actions Inactive
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the added coverage!

@meyskens meyskens force-pushed the meyskens/http-header-replace-test branch from fdd7924 to 5d6b9d0 Compare March 20, 2023 12:56
@meyskens meyskens temporarily deployed to ci March 20, 2023 12:56 — with GitHub Actions Inactive
@meyskens meyskens force-pushed the meyskens/http-header-replace-test branch from 5d6b9d0 to 89065d8 Compare March 21, 2023 08:25
This adds a test for the L7 policy to add/replace a HTTP header in a
request. It does this by sending a request to a new endpoint that
required an auth header, which will succeed if injected from a secret

Signed-off-by: Maartje Eyskens <[email protected]>
@meyskens meyskens force-pushed the meyskens/http-header-replace-test branch from 89065d8 to b3bce4f Compare March 21, 2023 08:27
@meyskens meyskens temporarily deployed to ci March 21, 2023 08:27 — with GitHub Actions Inactive
@meyskens meyskens marked this pull request as ready for review March 21, 2023 08:29
@meyskens meyskens requested a review from a team as a code owner March 21, 2023 08:29
@meyskens meyskens requested a review from squeed March 21, 2023 08:29
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@squeed
Copy link
Contributor

squeed commented Mar 21, 2023

This looks ready to merge - is the comment above still relevant?

@meyskens
Copy link
Member Author

The release got cut yesterday and PR updated

@tklauser tklauser merged commit 44cac8a into cilium:master Mar 21, 2023
@meyskens meyskens deleted the meyskens/http-header-replace-test branch March 22, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants