Don't enable nodeinit on EKS when not needed #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjsweet
approved these changes
Mar 16, 2023
nebril
force-pushed
the
pr/nebril/eks-nodeinit-older-versions
branch
from
5fb5357 to
e6e3e72
Compare
|
1.13.2 has required changes, I think it's OK to merge this one (after I figure out what happened with CI runs) |
nebril
force-pushed
the
pr/nebril/eks-nodeinit-older-versions
branch
from
e6e3e72 to
5a90cc7
Compare
nebril
force-pushed
the
pr/nebril/eks-nodeinit-older-versions
branch
from
5a90cc7 to
ac82106
Compare
nathanjsweet
approved these changes
Apr 25, 2023
joestringer
added
the
needs-rebase
Recent changes to helm charts make nodeinit not necessary on EKS, let's enable it only on older versions. Signed-off-by: Maciej Kwiek <[email protected]>
nebril
force-pushed
the
pr/nebril/eks-nodeinit-older-versions
branch
from
ac82106 to
19a6179
Compare
nebril
removed
the
needs-rebase
|
rebased, should be ready to merge after CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to helm charts make nodeinit not necessary on EKS, let's enable it only on older versions.
Don't merge it until cilium/cilium#24134 is backported and released (version check might require changes)