connectivity tests: fix issue on IPv6-only clusters #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPFamilyAny allows to select any IP address (regardless of the family). Signed-off-by: Marco Iorio <[email protected]>
This prevents the failure of the check when running on ipv6-only clusters. Signed-off-by: Marco Iorio <[email protected]>
squeed
approved these changes
Feb 27, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
IPFamilyNone(now renamed toIPFamilyAnyfor consistency) to allow both IPv4 and IPv6 addresses, and switches the "waitForPodDNS" check to use it is order to prevent issues on IPv6-only clusters.