status: detect when DaemonSets and Deployments are rolling out #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
commented
Feb 13, 2023
There are a few additional states that indicate a Deployment or DaemonSet is progressing and not yet fully deployed: - ObservedGeneration < Generation means the relevant controller has not yet observed the changes - UpdatedReplicas / UpdatedNumberScheduled too small means that the update has not fully rolled out. Fixes: cilium#413 which was somehow reverted in a refactor Signed-off-by: Casey Callendrello <[email protected]>
|
Test failure is a flake connecting to google.com. Definitely not related to this PR. re-pushed anyways to address goimport issue. |
squeed
force-pushed
the
status-check-generation
branch
from
b928b20 to
35b5885
Compare
tklauser
approved these changes
Feb 21, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few additional states that indicate a Deployment or DaemonSet is progressing and not yet fully deployed:
ObservedGeneration < Generation means the relevant controller has not yet observed the changes
UpdatedReplicas / UpdatedNumberScheduled too small means that the update has not fully rolled out.
Fixes: k8s: Check observedGeneration in status #413 which was somehow reverted in a refactor
Signed-off-by: Casey Callendrello [email protected]