k8s: Bring back TTY to Exec #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of commit 30310b1 ("connectivity, k8s, internal/utils: drop ExecInPodWithTTY and CtrlCReader"). Unfortunately, using the same context as StreamWithContext() to indicate a cancellation of a program running via Exec doesn't work as expected. From quick experimentation, it only closes a connection which doesn't necessarily send SIGTERM to a remote program. As a result, the tcpdump kept dangling in the encryption tests. Bring back the ctrlreader, and use a separate context for it. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/fix-exec-in-pod-kill
branch
from
6811b2f to
dc85fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of commit 30310b1 ("connectivity, k8s, internal/utils: drop ExecInPodWithTTY and CtrlCReader").
Unfortunately, using the same context as StreamWithContext() to indicate a cancellation of a program running via Exec doesn't work as expected. From quick experimentation, it only closes a connection which doesn't necessarily send SIGTERM to a remote program. As a result, the tcpdump kept dangling in the encryption tests.
Bring back the ctrlreader, and use a separate context for it.
Signed-off-by: Martynas Pumputis [email protected]